revert: add eslint-import-resolver-alias as dependency #3742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3742 +/- ##
=======================================
Coverage 61.55% 61.55%
=======================================
Files 35 35
Lines 1813 1813
Branches 365 365
=======================================
Hits 1116 1116
Misses 588 588
Partials 109 109 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3729, I removed
eslint-import-resolver-aliasbecause I didn't think we used it but turns out we do to make importing code-server plugins in a test.I don't fully understand exactly how it works, but it has to with aliasing a module (code-server itself as a module) in one of our tests. I tried putting it in the
test/package.jsonbut ESLint didn't like that.